Skip to content

Conversation

joefernandez
Copy link
Collaborator

  • Quickstart: split by language and reduce time
  • Build your agent: new section for agent building
  • Home page: Simplify onboarding choices
  • Surface "About ADK" in navigation

- Quickstart: split by language and reduce time
- Build your agent: new section for agent building
- Home page: Simplify onboarding choices
- Surface "About ADK" in navigation
Copy link
Collaborator

@koverholt koverholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the revisions! I listed a few optimizations for the Python page, and the Java quickstart page needs some additional reworking. Overall I love the more streamlined getting started pages and the reorganization of the "Build your agent" tutorials!

- completely revised Java quickstart
Copy link
Collaborator

@koverholt koverholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates, the updated Java quickstart page is looking great! The main blocking issue that I ran into is on the Java quickstart page when running with the web UI, and I left a few other minor comments.


```shell
```bash title="Update: my_agent/.env"
echo 'export GOOGLE_API_KEY="YOUR_API_KEY"' > .env
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
echo 'export GOOGLE_API_KEY="YOUR_API_KEY"' > .env
echo 'GOOGLE_API_KEY="YOUR_API_KEY"' > .env

These are read in as key-value pairs, so no need to export to the current environment.

=== "MacOS / Linux"

```bash title="Update: my_agent/.env"
echo 'export GOOGLE_API_KEY="YOUR_API_KEY"' > .env
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
echo 'export GOOGLE_API_KEY="YOUR_API_KEY"' > .env
echo 'GOOGLE_API_KEY="YOUR_API_KEY"' > .env

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This image matches the output of the Java-based agent and tool, but the Python-based agent will return:

I am sorry, I cannot provide the time for London.

Should we use different images to match the output of each agent? Or refactor so the agent's tool implementation is the same and thus the output is the same?


![adk-web-dev-ui-chat.png](../assets/adk-web-dev-ui-chat.png)
This command starts a web server with a chat interface for your agent. You can
access the web interface at (http://localhost:8080). Select the agent at the
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
access the web interface at (http://localhost:8080). Select the agent at the
access the web interface at (http://localhost:8000). Select the agent at the

The default port in Python for adk web is 8000.

Comment on lines +93 to +95
This project uses the Gemini API, which requires an API key. If you
don't already have Gemini API key, create a key in Google AI Studio on the
[API Keys](https://aistudio.google.com/app/apikey) page.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This project uses the Gemini API, which requires an API key. If you
don't already have Gemini API key, create a key in Google AI Studio on the
[API Keys](https://aistudio.google.com/app/apikey) page.
This quickstart uses the Gemini API in Google AI Studio, which requires an API
key. If you don't already have a Gemini API key, create a key in Google AI
Studio on the [API Keys](https://aistudio.google.com/app/apikey) page.

Comment on lines +15 to +16
src/main/java/com/example/agent/
HelloTimeAgent.java # main agent code
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
src/main/java/com/example/agent/
HelloTimeAgent.java # main agent code
src/main/java/com/example/agent/HelloTimeAgent.java # main agent code

Suggest unwrapping this line to remove ambiguity.

Create an agent project with the following files and directory structure:

```console
my_agent/
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming that the my_agent/src/main/java/com/example/agent/AgentCliRunner.java file is a required / core part of the Java quickstart, should we add this file here as well to ensure its creation for later?

Comment on lines 232 to 234
```console
mvn compile exec:java -Dexec.mainClass="com.example.agent.AgentCliRunner"
```
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this with ADK Java, and it's working as expected. Thanks!

Comment on lines +242 to +244
```console
mvn compile exec:java -Dexec.mainClass="com.google.adk.web.AdkWebServer" \
-Dexec.args="--adk.agents.source-dir=src/main/java/com/example/agent --server.port=8080"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this and was unable to get it to detect the agent:

Screenshot 2025-10-08 at 10 49 05 AM

I tried running in different working directories, and I tried different source-dirs, but I couldn't get it to pull up the quickstart agent.

- Java: get-started/streaming/quickstart-streaming-java.md
- Testing: get-started/testing.md
- Code samples: https://github.com/google/adk-samples
- Advanced setup: get-started/installation.md
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the contents of this page, do we want to update the pom.xml to match the latest versions shown on the Java quickstart page? Or should we go ahead and remove this page in this PR for now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants